[MCC-1476014] Python Lib-Create Fetch_data() function - #21
Closed
afieraru-mdsol wants to merge 4 commits into
Closed
[MCC-1476014] Python Lib-Create Fetch_data() function#21afieraru-mdsol wants to merge 4 commits into
afieraru-mdsol wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new fetch_data() capability to the DataConnect Python SDK, wiring a new service action through the Arrow Flight transport, service layer, and public client API.
Changes:
- Add a new Arrow Flight action mapping for
"data.fetch_ticket". - Add
fetch_data()to the service interface and implement it in the default service. - Expose
fetch_data()onDataConnectClientand add a mapper intended to return pandas DataFrames.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| dataconnect/transport/arrow_flight/transport.py | Adds Arrow Flight action mapping for the new data fetch action. |
| dataconnect/service/mappers.py | Introduces a new mapper intended to convert a ResourceInfo into a pandas DataFrame. |
| dataconnect/service/default.py | Implements fetch_data() by issuing a ResourceQuery and mapping results. |
| dataconnect/service/base.py | Extends the DataConnectService interface with fetch_data(). |
| dataconnect/client.py | Adds a fetch_data() method to the public client API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/bug/enhance/refactor/tech_debt/hotfix
MCC-1476014Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary